Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the check for ":0@0" in CLUSTER NODES result #199

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Fix the check for ":0@0" in CLUSTER NODES result #199

merged 2 commits into from
Feb 9, 2024

Commits on Jan 3, 2024

  1. Fix the check for the 'ip:port@cport' part when parsing a line in the… 

    … 'cluster nodes' result. The current implementation assumes that the entire part is only 2 characters when the IP and port are not set (IP is empty and port is 0). However, this is incorrect because the '@cport' is also present so the current check fails. Additionally, there may be an optional ',hostname' as well which is not accounted for.
    @KevinLussier-Netskope
    KevinLussier-Netskope committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    ff3cd20 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. Use memcmp

    @zuiderkwast
    zuiderkwast authored Feb 9, 2024
    Configuration menu
    Copy the full SHA
    1bc31a9 View commit details
    Browse the repository at this point in the history