Fix builds when using CMake < v3.15 and preinstalled hiredis
#196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMake before version 3.15 does not support creating an ALIAS library for a library of UNKNOWN type via its command add_library(). Due to other fixes we can now skip the alias step when importing an already installed hiredis library and use correct name directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake before version 3.15 does not support creating an
ALIASlibrary for a library ofUNKNOWNtype via its commandadd_library().Due to other fixes we can now skip the alias step (
hiredis->hiredis:hiredis) when importing an already installedhiredislibrary and give it correct name directly in our CMakeLists.txt.The created
hiredis:hiredislibrary reference is required by CMake to be able to buildhiredis-cluster.hiredis::hiredis_sslis handled in the same fashion.Fixes #173