Fix timing issues in flaky scaledown tests #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terminate a clusterclient directly instead of first closing its client socket. This avoids that hiredis-cluster might succeed to reconnect to the server before the server has shutdown. Close the simulated-redis's listener socket early improves stability. Add check for alternative output from clusterclient in testcase cluster-scale-down-test.sh, which depends on timing.
zuiderkwast
reviewed
Sep 4, 2023
tests/scripts/dbsize-to-all-nodes-during-scaledown-test-async.sh
Outdated
Show resolved
Hide resolved
tests/scripts/dbsize-to-all-nodes-during-scaledown-test-async.sh
Outdated
Show resolved
Hide resolved
|
I'll rerun the checks in an hour, I've seemed to trigger API rate limiter with all my testing. |
zuiderkwast
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Terminate a clusterclient directly instead of first closing its client socket.
This avoids that hiredis-cluster might succeed to reconnect to the server before the server has shutdown.
Close the simulated-redis's listener socket early improves stability.
Add check for alternative output from clusterclient in testcase
cluster-scale-down-test.sh,dbsize-to-all-nodes-during-scaledown-test.shanddbsize-to-all-nodes-during-scaledown-test-async.sh, which depends on timing.