Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update slotmap on error #182

Merged
merged 11 commits into from
Aug 29, 2023
Merged

Update slotmap on error #182

merged 11 commits into from
Aug 29, 2023

Conversation

zuiderkwast
Copy link
Collaborator

@zuiderkwast zuiderkwast commented Aug 25, 2023 •
edited
Loading

  • When connect failed, update slotmap instead of sending command to random node.
  • When command times out (etc.) schedule slotmap update for next command
  • A few changed error messages

Fixes #178
Fixes #85

bjosv
bjosv reviewed Aug 28, 2023
View reviewed changes
hircluster.c Show resolved Hide resolved
bjosv
bjosv reviewed Aug 28, 2023
View reviewed changes
hircluster.c Outdated Show resolved Hide resolved
@zuiderkwast zuiderkwast marked this pull request as ready for review August 28, 2023 14:00
bjosv
bjosv reviewed Aug 29, 2023
View reviewed changes
Copy link
Collaborator

@bjosv bjosv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Some new things I've seen after a second look.

hircluster.c Outdated Show resolved Hide resolved
hircluster.c Outdated Show resolved Hide resolved
bjosv
bjosv approved these changes Aug 29, 2023
View reviewed changes
Copy link
Collaborator

@bjosv bjosv left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Splendid.

@zuiderkwast zuiderkwast merged commit e1fde9b into Nordix:master Aug 29, 2023
32 checks passed
@zuiderkwast zuiderkwast deleted the update-slotmap-on-error branch August 29, 2023 08:50
This was referenced Aug 29, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjosv bjosv bjosv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the slotmap after send errors/timeouts in the sync API Support cluster scale down (AWS)
2 participants
@zuiderkwast @bjosv