Prefix some API functions and types correctly #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zuiderkwast
reviewed
Aug 23, 2023
zuiderkwast
reviewed
Aug 23, 2023
bjosv
force-pushed
the
api-fixes
branch
3 times, most recently
from
ff8f1ef
to
9133f86
Compare
zuiderkwast
approved these changes
Aug 24, 2023
Comment on lines
+492
to
+493
| First it needs to be initiated using `redisClusterInitNodeIterator()` and then you can repeatedly | ||
| call `redisClusterNodeNext()` to get the next node from the iterator. |
There was a problem hiding this comment.
Should we add the prototypes (or an example) here so the users don't need to look in the header file?
There was a problem hiding this comment.
Good, I added the prototype as it is done for most other commands.
nodeIterator -> redisClusterNodeIterator initNodeIterator(..) -> redisClusterInitNodeIterator(..) nodeNext(..) -> redisClusterNodeNext(..) HIRCLUSTER_NO_OLD_NAMES can be defined when backward compability with old types or function names is not needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename node iterator type and its functions:
nodeIteratortoredisClusterNodeIteratorinitNodeIterator(..)toredisClusterInitNodeIterator(..)nodeNext(..)toredisClusterNodeNext(..)Renaming of:
cluster_update_routetoredisClusterUpdateSlotMap()Old names are still defined for backward compability,
but
HIRCLUSTER_NO_OLD_NAMEScan be defined when backward compability with old types or function names is not needed.