-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimizes int types for in memory storage #460
base: main
Are you sure you want to change the base?
Conversation
Dinne Bosman seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
I have not been able to run the tests! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
One line length issue (see comment). Also, please rebase your branch to a single non-merge commit
@dwjbosman Thanks for your contribution! I have taken your code and made a number of fixes and improvments to it, which you can find at #466. Feel free to grab that commit into this PR, and possibly add you own Signed-off-by line ( |
When having large arrays of a type that has a small range, the code generator should use the correct integer type to avoid wasting precious memory.
Fix for #459