Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimizes int types for in memory storage #460

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

dwjbosman
Copy link

When having large arrays of a type that has a small range, the code generator should use the correct integer type to avoid wasting precious memory.

Fix for #459

@CLAassistant
Copy link

CLAassistant commented Oct 16, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ oyvindronningstad
✅ dwjbosman
❌ Dinne Bosman


Dinne Bosman seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@dwjbosman
Copy link
Author

I have not been able to run the tests!

Copy link
Collaborator

@oyvindronningstad oyvindronningstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

One line length issue (see comment). Also, please rebase your branch to a single non-merge commit

zcbor/zcbor.py Outdated Show resolved Hide resolved
@oyvindronningstad
Copy link
Collaborator

@dwjbosman Thanks for your contribution! I have taken your code and made a number of fixes and improvments to it, which you can find at #466. Feel free to grab that commit into this PR, and possibly add you own Signed-off-by line (git commit --amend -s). The commit is based on your work and is in your name as author. If I don't hear from you I will put myself as author so as not to impersonate you, and instead credit you in the commit message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants