zcbor.py: Add support for unordered maps in generated code #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oyvindronningstad
force-pushed
the
map-search-py
branch
2 times, most recently
from
10152df
to
36e9986
Compare
oyvindronningstad
requested review from
hakonfam,
sigvartmh,
karstenkoenig,
jonathannilsen and
anhmolt
oyvindronningstad
force-pushed
the
map-search-py
branch
2 times, most recently
from
f32fa46
to
087ba75
Compare
oyvindronningstad
force-pushed
the
map-search-py
branch
from
087ba75
to
784c7c2
Compare
oyvindronningstad
force-pushed
the
map-search-py
branch
8 times, most recently
from
40b1e6b
to
60ba45c
Compare
Add support for the --unordered-maps option to zcbor code which makes use of the zcbor_unordered_maps_*() API in generated code. Signed-off-by: Øyvind Rønningstad <[email protected]>
oyvindronningstad
force-pushed
the
map-search-py
branch
from
60ba45c
to
1f2aa22
Compare
|
@oyvindronningstad Any traction here? Will we get this for NCS 2.8? |
darkofc
reviewed
Oct 22, 2024
| @@ -530,7 +530,7 @@ static inline size_t zcbor_flags_to_states(size_t num_flags) | |||
| #define ZCBOR_FLAG_STATES(n_flags) zcbor_flags_to_states(n_flags) | |||
There was a problem hiding this comment.
The changes to zcbor.py is using ZCBOR_FLAG_STATES() in the states[] array size. The IAR C Compiler does not allow inline methods in array size declarations. I was able to work around this by expanding the ZCBOR_FLAG_STATES() macro and not calling zcbor_flags_to_states() (which is then unused and can be removed) . Not sure if that is the best solution, but seems to be working:
#define ZCBOR_ROUND_UP(x, align) (((x) + (align) - 1) / (align) * (align))
#define ZCBOR_FLAG_STATES(num_flags) (ZCBOR_ROUND_UP(num_flags, sizeof(zcbor_state_t) * ZCBOR_BITS_PER_BYTE) / (sizeof(zcbor_state_t) * ZCBOR_BITS_PER_BYTE))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the --unordered-maps option to zcbor code
which makes use of the zcbor_unordered_maps_*() API in generated code.
Fixes #411