Normalize case handling for objects and callbacks #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Savolro
previously approved these changes
Oct 31, 2023
Objects and callbacks were not handling case consistently in generated across code, leading to compilation errors in some cases (see #22). The main problem arises in capital acronym handling, i.e. `HTTPClient`. Such acronyms are converted using `heck::to_upper_camel_case`, which converts upper case acronym `HTTP` into upper camel case `Http`, i.e. `HttpClient`.
arg0d
force-pushed
the
kristupas/case-handling-object-callbacks
branch
from
f327880
to
f46d8d3
Compare
Savolro
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objects and callbacks were not handling case consistently in generated across code, leading to compilation errors in some cases (see #22).
The main problem arises in capital acronym handling, i.e.
HTTPClient. Such acronyms are converted usingheck::to_upper_camel_case, which converts upper case acronymHTTPinto upper camel caseHttp, i.e.HttpClient.Fixes #22.