Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flag to fail fast when downloading .so during build #670

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −0
Open

Add flag to fail fast when downloading .so during build #670

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ci/check_dependencies.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ function fetch_gitlab_artifact() {
curl \
--retry 3 \
--retry-delay 2 \
--fail-with-body \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it needed to save the document at failure? Or this is just for debugging?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for debugging. We can go with just --fail without saving the body and the status of the http call should be enough to figure out what's wrong, but the status can be easily missed, so I left the --fail-with-body

--header "PRIVATE-TOKEN: ${GL_ACCESS_TOKEN}" \
-o "${out_file}" \
-L "${artifact_url}"
Expand Down
Loading