-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve error reporting when EasyBuild PR is not merged #299
improve error reporting when EasyBuild PR is not merged #299
Conversation
…SI specific strings
Instance
|
Instance
|
Instance
|
Instance
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All test cases succeeded after including necessary changes. More work than thought it would be, but useful to get it right.
Integrated changes of two other related PRs.
…into nessi_improve_error_reporting
This is a PR to sync NESSI with EESSI. See #294
Particularly this PR is for addressing
code
changes added to EESSI in EESSI#494Here we simply pulled in changes for the three changed files in the EESSI PR (via
git checkout casparvl/improve_error_on_unmerged_pr -- ONE_FILE
withONE_FILE
in {check_missing_installations.sh
,EESSI-install-software.sh
,bot/check-build.sh
) and thereafter changed back to using NESSI as name in two comments.Since this PR involves quite a few changes we should test it with some basic PR building some software for EasyBuild PRs that are merged and not-merged (two separate tests).
Tests. We run a couple of tests with modifications by this PR and without them with EasyBuild easyconfig PRs that are merged or unmerged. Depending on the scenario, we should see differences in the reported outcome (FAILURE/SUCCESS) and differences in the ERROR message in cases of FAILURE. NOTE, the actual build should always succeed (need to check this carefully in the logs):
check_missing_installations.sh
, see logic to determinefrom-pr
fails when.diff
files includes extra 'from-pr' EESSI/software-layer#536For letting CI succeed, #303 needs to get merged first.