Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
align_pair
function in the sorting.jl file can be optimized in the following ways:Avoid unnecessary computations: You're computing the sortperm of the entire distances matrix, which is an O(n^2) operation. However, you only need the minimum distance for each reference, which can be found in O(n) time.
Use efficient data structures: You're using arrays to keep track of which elements have been matched. Consider using a Set for this, which has O(1) lookup time.
From
to