Remove getindex function for OrderedDict
#141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oameye
added
the
formatting
jdelpino
reviewed
Jan 4, 2024
|
I normally checked, but I agree we need more tests. This is one of my todo's and with the seed PR it will be a lot easier to write better tests. |
|
So is this good to merge? This needs to go, redefining a package method results in the kind of bugs that take hours to fix. |
|
Yes, this can be merged |
jkosata
approved these changes
Jan 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
getindexfunction forOrderedDictas it was unintuitive and not used internally.Should only be merged after #134 and #138