Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Limit_cycle module compatible with the linear response module #112

Merged
merged 7 commits into from
Nov 19, 2023

Conversation

oameye
Copy link
Member

@oameye oameye commented Sep 13, 2023

  • Check on a toy model if gives the right results

@oameye oameye marked this pull request as draft October 10, 2023 14:17
@jkosata
Copy link
Member

jkosata commented Nov 11, 2023

Is it ok if I pick this up or do you have some more local stuff to push? I was going to write a short doc page for the limit cycles to submit with our revised paper

@oameye
Copy link
Member Author

oameye commented Nov 12, 2023

@jkosata Yes ofcourse! Feel free to push this forward. Maybe, merge master with this branch first, before you continue.

@jkosata
Copy link
Member

jkosata commented Nov 12, 2023

Rebased to master and did some minor touches, more coming

@jkosata
Copy link
Member

jkosata commented Nov 19, 2023

I've brushed up the LimitCycles module so that our new paper is reproducible, removed a small bug, added an example doc.

The output of plot_linear_response for limit cycles looks reasonable and we've used it successfully before, but I can't think of a simple test.

@jkosata jkosata marked this pull request as ready for review November 19, 2023 10:47
@jdelpino jdelpino merged commit 7935f71 into master Nov 19, 2023
2 checks passed
@jdelpino jdelpino deleted the Limit_cycle_linear_response branch November 19, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants