You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because this PR includes a bug fix, relevant tests have been included.
Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.
I didn't do anything of this.
This PR introduces the agreed upon workaround for npms inability to publish .gitignore files (see npm/npm#3763).
Going through the comments on the linked issue, it seems that the most common convention for working around this issue is exactly what we came up with, too - which is to copy gitignore template files as .gitignore workspace files.
I left .gitignore files in the templates because it is useful to have, for example, node_modules gitignored during development.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Interestingly enough pnpm pack does respect explicit templates/**/.gitignore in files of package.json but I'm not sure if we can/should rely on it (in particular, I don't think pnpm changeset publish would respect it but I haven't tried).
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
galargh
force-pushed
the
init-gitignore
branch
from
This PR introduces the agreed upon workaround for
npms inability to publish.gitignorefiles (see npm/npm#3763).Going through the comments on the linked issue, it seems that the most common convention for working around this issue is exactly what we came up with, too - which is to copy
gitignoretemplate files as.gitignoreworkspace files.I left
.gitignorefiles in the templates because it is useful to have, for example,node_modulesgitignored during development.