Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Slang to 0.15.1 #578

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Update Slang to 0.15.1 #578

merged 2 commits into from
Jun 17, 2024

Conversation

OmarTawfik
Copy link
Contributor

  • Fixes a bug in CI scripts where it ignores outdated lock files. Now we run npm ci to actually check for that.
  • Upgraded to the newest Slang release, and updating the lock file accourdingly.
  • Additionally, now we parse/cache all queries once for all feature requests, instead of repeating it with each incoming one.
  • Added unit tests for the queries, to make it easier to detect syntax errors in test failures, rather than launching the editor and inspecting the error logs of the server.

@OmarTawfik OmarTawfik merged commit 6c2b803 into NomicFoundation:development Jun 17, 2024
9 of 10 checks passed
@OmarTawfik OmarTawfik deleted the update-slang-version branch June 17, 2024 14:58
OmarTawfik added a commit to OmarTawfik-forks/hardhat-vscode that referenced this pull request Jun 25, 2024
@OmarTawfik
chore: bump version to v0.8.4
a2155d8 
Update the package version and changelog for the `0.8.4 - 2024-06-24` release.

### Added

- add markdown syntax support ([575](NomicFoundation#575))
- Bump Slang to 0.15.1 ([578](NomicFoundation#578))
@OmarTawfik OmarTawfik mentioned this pull request Jun 25, 2024
Merged
OmarTawfik added a commit that referenced this pull request Jun 28, 2024
@OmarTawfik
Update Slang to 0.15.1 (#578)
a747936 
* use latest `npm ci` to make sure lock files are up to date

* upgrade to Slang v0.15.1
OmarTawfik added a commit that referenced this pull request Jun 28, 2024
@OmarTawfik
chore: bump version to v0.8.4
22fcbb7 
Update the package version and changelog for the `0.8.4 - 2024-06-24` release.

### Added

- add markdown syntax support ([575](#575))
- Bump Slang to 0.15.1 ([578](#578))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xanewok Xanewok Xanewok approved these changes

@AntonyBlakey AntonyBlakey Awaiting requested review from AntonyBlakey

Assignees
No one assigned
Labels
status:triaging
Projects
hardhat-vscode
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OmarTawfik @Xanewok