Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add foundryup support for Windows #515

Open
wants to merge 2 commits into
base: development
Choose a base branch
from
Open

Add foundryup support for Windows #515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c7d5b6
docs: add .env warning to publish instructions
kanej May 31, 2023
af82c8d
Add `foundryup` support for Windows
akshatmittal Aug 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docs/publish-extension.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ release.

9. Push the release branch and open a pull request using the new changelog entry as the PR description
10. Generate a release candidate vsix file with `npm run package`, the vsix file should appear in the `./client` folder with the new version number

> NOTE: ensure .env file is populated with GA and Sentry secrets before packaging (see `./env.example`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we drop this change, please?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the dev branch pulled back? I didn't add that. @kanej

But yeah, kinda cool that the PR is still valid after 10 months.


11. Manually run smoke tests on the new features across:

- mac os x
Expand Down
3 changes: 3 additions & 0 deletions server/src/frameworks/Foundry/resolveForgeCommand.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ export async function resolveForgeCommand() {
potentialForgeCommands.push(
`${process.env.USERPROFILE}\\.cargo\\bin\\forge`
);
potentialForgeCommands.push(
`${process.env.USERPROFILE}\\.foundry\\bin\\forge`
);
} else {
potentialForgeCommands.push(
`${process.env.XDG_CONFIG_HOME || process.env.HOME}/.foundry/bin/forge`
Expand Down
Loading