Shell Handling Library for Line Editing #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PlatformIO kept exploding when trying to build the `microrl-remastered` library because of the folder structure. Resolved by vendoring v2.5.0 and including our `_user_config.h` in the source folder, finally making the compile process happy. WIP: debugging microrl+Commander shell-lib: use TeePrint for most outputs, Commander switches ports shell-lib: add vendored microrl library info shell-lib: check for cli streaming for both input ports Moves the `adc dump` ending check into `cli_loop()` so that both streams can be monitored. Also gets away from checking `cli->getInputPort()` which is now a NULL to work with `microrl` shell-lib: fixup! stop Streaming when a command is run Too much potential for an extra character in the buffer to stop the streaming prematurely. So, instead just wait until a command is executed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3 by adding the dimmykar/microrl-remaster library between the input streams and Commander.