Add markdown-it-multimd-table, resolves #113 #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows colspan and rowspan attributes in table elements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #113
Added markdown-it-multimd-table to package.json, and created a setting to enable or disable it (
multimdTables). I also had to addcolspanandrowspanas attributes tothandtdin sanitizer config, because otherwise they were filtered out.A checkbox to toggle this setting was also added to ACP - the decision to add it to the first of the two available columns was one of aesthetics since the other way seems a bit... unbalanced:
The way it looks now:
Also, I decided against separate settings for options included in markdown-it-multimd-table, that is:
And set them all to
trueto simplify the configuration. If you believe it to be a bad idea, I'll add these settings separately :)Quick test using examples from multimd-table readme and the multiline table from the community post confirms that the plugin works as intended:
