Adding the rest of Assassin's Skills and Abilities #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All skills and abilities implemented.
kenedos
reviewed
Nov 14, 2024
| @@ -647,7 +647,7 @@ public float SCR_GetCritChance(ICombatEntity attacker, ICombatEntity target, Ski | |||
| return 100; | |||
|
|
|||
| var critDodgeRate = target.Properties.GetFloat(PropertyName.CRTDR); | |||
| var critHitRate = attacker.Properties.GetFloat(PropertyName.CRTHR) + modifier.BonusCritChance; | |||
| var critHitRate = attacker.Properties.GetFloat(PropertyName.CRTHR) * modifier.CritRateMultiplier + modifier.BonusCritChance; | |||
There was a problem hiding this comment.
Just a quick note here but multiplying the CRTHR by 2 (for Annihilation ability bonus) is not the same as multiplying the critChance variable by 2 due to the exponential formula it has.
Example:
critHitRate = 200
critDodgeRate = 50
No Annihilation Buff:
(200 - 50) ^ 0.6 = 20.2% crit chance
Annihilation Buff (2x Crit Chance):
(400 - 50) ^ 0.6 = 33.6% crit chance
There was a problem hiding this comment.
You're correct, this probably also applies to BonusCritChance as well.
kenedos
reviewed
Nov 14, 2024
| modifier.HitCount = 10; | ||
|
|
||
| // Assassin15 adds double crit rate to bleeding targets | ||
| if (caster.IsAbilityActive(AbilityId.Assassin15) && (target.IsBuffActive(BuffId.HeavyBleeding) || target.IsBuffActive(BuffId.Behead_Debuff))) |
There was a problem hiding this comment.
Assassin15 is the Annihilation enhance damage ability. Don't you mean Assassin17?
There was a problem hiding this comment.
Good catch, it is indeed Assassin17.
kenedos
reviewed
Nov 14, 2024
| { | ||
| /// <summary> | ||
| /// Handler for the ThrouwingSpear_Hoplite33_Pad, | ||
| /// which displays an explosion effect in a given position |
Based on Kenedos' comments
kenedos
reviewed
Nov 16, 2024
| [SkillHandler(SkillId.Assassin_HallucinationSmoke)] | ||
| public class Assassin_HallucinationSmoke : IGroundSkillHandler | ||
| { | ||
| private readonly static TimeSpan DebuffDuration = TimeSpan.FromSeconds(5); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All skills and abilities implemented, including the removed abilities.
Note that Common_Silence is implemented in Outlaw, so I haven't included it here.