Outlaw's skills #333
Outlaw's skills #333
Conversation
Brick Smash, Throw Sand, Mangle
All skills implemented
All abilities implemented
|
|
||
| hits.Add(skillHit); | ||
|
|
||
| target.StartBuff(BuffId.Common_Silence, skill.Level, 0, TimeSpan.FromMilliseconds(200 * skill.Level), caster); |
There was a problem hiding this comment.
In Peltasta's Langort you are using Silence_Debuff, is there a reason to use Common_Silence here?
There was a problem hiding this comment.
The skill_bytool for Outlaw specifically names Common_Silence as the debuff. Langort might be incorrect, as the comment indicates the buff is not in the bytool, so I may have chosen the wrong Silence debuff, though multiple buffs with the same effect in this game is not uncommon.
| /// <summary> | ||
| /// Increases the buff's duration by a given amount. | ||
| /// </summary> | ||
| internal void IncreaseDuration(TimeSpan amount) |
There was a problem hiding this comment.
Probably better to merge IncreaseDuration() and ExtendDuration() into a single method.
There was a problem hiding this comment.
I agree this is somewhat confusing and maybe the description should have been a little more clear, but ExtendDuration has several features we don't want here, most particularly that it resets the updatetime on the buff. We probably don't want to constantly call onExtend here either.
Adds all 7 skills for outlaw and all of their abilities, including the removed ones.