-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
craft-docs: init at 2.8.8 #359102
base: master
Are you sure you want to change the base?
craft-docs: init at 2.8.8 #359102
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally, there should be only two commits, the first adding yourself to the maintainers list, one adding the package, please squash down to two and force push
''; | ||
|
||
meta = { | ||
description = "Craft the best docs in the world"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a more descriptive version of this? It is not clear what the package does from this description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's their slogan. I added some extra information in this commit, let me know if it works.
How often does this update? |
I'm not sure exactly how often it updates. The only date I can find is that version 2.8.6 was released around WWDC in June. Since the latest version is 2.8.8, that would place minor updates at around once every 2.5 months. It would be difficult to use on stable releases. Hopefully, this method is not permanent. Ideally, I can come to an arrangement with them to host multiple versions of the software. |
It would be impossible to use on stable releases, unless maybe I don't know if there is a system for including a derivation in unstable only, but having a permanently broken derivation in a stable release would be an unfortunate situation. Anyhow, I am not a committer, so that is not my decision to make |
26fdfa4
to
b15291b
Compare
Sorry for the force-push, I'm having git troubles. Your concerns should be fixed now.
Impossible at least some of the time, yes.
This would be a nice solution, but the licensing concerns are a problem. That's one of the options I'm discussing with them.
I agree. I'd very much like for this to be a temporary bodge until a proper solution can be found. (At that point, I will implement it and create a new PR.) |
One way to get around the issue of unstable download links is to preserve them via the Wayback Machine, which had been done for some proprietary packages. Though, the more we use them, the more iffy I feel about them because we really should not rely on/abuse an external service like that (remember when archive.org went dark for weeks?) Still, that is a discussion best reserved for a separate issue |
Hydra does not build and cache unfree packages, not even redistributable ones (see #83884). Therefore we could not count on cache.nixos.org caching the DMG file at all — because it won't. |
Good to know. Do you know of any way this could work then, other than upstream providing direct download links for specific versions? |
I don't really know. We could always debate about it in #359366, though |
b15291b
to
0817d73
Compare
Create a package for craft-docs, as in #359033. Will break as soon as Craft updates, as there is no method of downloading a specific, stable version. I am in discussion with their team to establish such a method, but until then, it'll have to be manually updated as quickly as possible as new versions come in to prevent breakage.
Things done
Note: package only supports darwin. Should work on x86_64-darwin, but I have no way of testing currently.
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.