argocd: upgrade and add fish completions #358264
Open
+7
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
znd4
commented
Nov 22, 2024
| # NOTE: Update kubectlVersion when upgrading this package with | ||
| # https://github.com/argoproj/argo-cd/blob/v${version}/go.mod#L95 | ||
| # Per https://github.com/argoproj/argo-cd/blob/master/Makefile#L18 | ||
| # https://github.com/search?q=repo%3Aargoproj%2Fargo-cd+%22k8s.io%2Fkubectl%22+path%3Ago.mod&type=code |
There was a problem hiding this comment.
Made this change b.c. it felt like it'll become stale less often. Happy to stick with the older links though.
Also, it'd be really nice if github search links could include versions
znd4
force-pushed
the
argocd-2.13
branch
3 times, most recently
from
d8b0423
to
eabcdd8
Compare
|
I'm hoping it's okay to have tested without |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.