Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rerun: 0.18.2 -> 0.20.1 #358093

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

rerun: 0.18.2 -> 0.20.1 #358093

wants to merge 1 commit into from

Conversation

nim65s
Copy link
Contributor

@nim65s nim65s commented Nov 22, 2024

changelog: https://github.com/rerun-io/rerun/blob/main/CHANGELOG.md

The rust version patch is not required anymore.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@SomeoneSerge
Copy link
Contributor

Seems like the deps hash is platform dependent now 🤢

@RobWalt
Copy link
Contributor

RobWalt commented Nov 23, 2024

Just had a successful build 👍

@SomeoneSerge What exactly do you mean? I just want to understand. Can you please elaborate?

@nim65s
Copy link
Contributor Author

nim65s commented Nov 23, 2024

Seems like the deps hash is platform dependent now 🤢

I did build this package on both x86_64-linux and aarch64-darwin with the same deps hash, so I don't understand your point.

@SomeoneSerge
Copy link
Contributor

SomeoneSerge commented Nov 24, 2024

Sorry for the delay, I was referring to the ofborg report for x86_64-darwin:

patching script interpreter paths in /nix/store/rkxf1c04ns24kilnrm6hv3i9c7wdblzf-rerun-0.20.1-vendor.tar.gz
error: hash mismatch in fixed-output derivation '/nix/store/p7j2c37qa6mf6lppgqj7x6irxp9v4xnz-rerun-0.20.1-vendor.tar.gz.drv':
         specified: sha256-APo3AjKM3n/lS5QZg0VEW83RAZIm6T5/itADPQ4qSNs=
            got:    sha256-CIPjJSoHUAF8tCU4NNclsIViu9hWwmsVYpjvySRqqfc=

I did build this package on both x86_64-linux and aarch64-darwin with the same deps hash, so I don't understand your point.

H'm, should we tell ofborg to give it another try


P.S. The non-python app runs fine on x86_64-linux with wayland

@nim65s
Copy link
Contributor Author

nim65s commented Nov 25, 2024

Hum, maybe something went wrong when ofborg tried to download stuff ?
I'd be in favor of just trying a second time, yes

@SomeoneSerge
Copy link
Contributor

@ofborg build rerun

@SomeoneSerge
Copy link
Contributor

@nim65s same error: https://github.com/NixOS/nixpkgs/pull/358093/checks?check_run_id=33483089572

I would guess you must've got sha256-APo3AjKM3n/lS5QZg0VEW83RAZIm6T5/itADPQ4qSNs= cached in the local store (can be verified by --rebuilding the fod)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants