Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rquickshare: build from source #357673

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HannesGitH
Copy link
Contributor

fixes #357017

rquickshare is now build from source instead of wrapping the appimage, this -alongside other benifits- allows it to be compatible with multiple platforms

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@HannesGitH
Copy link
Contributor Author

@luftmensch-luftmensch as i removed all of your changes i also removed you from the list of maintainers for this package, if you feel like still mainting this package, lmk i'll re-add you :)

@luftmensch-luftmensch
Copy link
Contributor

There is no need to remove me as a maintainer...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update request: rquickshare build from source
2 participants