Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prismlauncher-unwrapped: adopt new darwin SDK pattern #357193

Merged
merged 1 commit into from
Nov 19, 2024
Merged

prismlauncher-unwrapped: adopt new darwin SDK pattern #357193

merged 1 commit into from
Nov 19, 2024

Conversation

Scrumplex
Copy link
Member

@Scrumplex Scrumplex commented Nov 19, 2024 •
edited
Loading

Tracking issue #354146

ZHF #352882

https://hydra.nixos.org/build/279419536

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Scrumplex Scrumplex added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label Nov 19, 2024
@Scrumplex
Copy link
Member Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 357193

x86_64-linux

x86_64-darwin

✅ 2 packages built:
  • prismlauncher
  • prismlauncher-unwrapped

aarch64-darwin

✅ 2 packages built:
  • prismlauncher
  • prismlauncher-unwrapped

@getchoo getchoo added 11.by: upstream-developer This issue or PR was created by the developer of packaged software 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package 6.topic: darwin Running or building packages on Darwin 0.kind: build failure A package fails to build backport release-24.11 Backport PR automatically labels Nov 19, 2024
@Scrumplex Scrumplex merged commit d7bead5 into NixOS:master Nov 19, 2024
27 of 28 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-24.11:

@github-actions github-actions bot mentioned this pull request Nov 19, 2024
Merged
1 task
@getchoo getchoo mentioned this pull request Nov 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@getchoo getchoo getchoo approved these changes

Assignees
No one assigned
Labels
0.kind: build failure A package fails to build 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 6.topic: darwin Running or building packages on Darwin 11.by: upstream-developer This issue or PR was created by the developer of packaged software 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Scrumplex @getchoo