Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ostree: 2024.4 -> 2024.8 #353599

Merged
merged 1 commit into from
Nov 5, 2024
Merged

ostree: 2024.4 -> 2024.8 #353599

merged 1 commit into from
Nov 5, 2024

Conversation

rawkode
Copy link
Member

@rawkode rawkode commented Nov 4, 2024 •
edited
Loading

ostree 2024.4 with curl 8.10.0 do not work, breaking many downstrteam packages; such as flatpaks

ostreedev/ostree#3299

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@rawkode
ostree: 2024.4 -> 2024.8
76c8e15 
ostree 2024.4 with curl 8.10.0 do not work, breaking
many downstrteam packages; such as flatpaks

ostreedev/ostree#3299
@rawkode rawkode requested a review from danielbarter November 4, 2024 08:10
JohnRTitor
JohnRTitor approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@JohnRTitor JohnRTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

  nix run github:nixos/nixpkgs/refs/pull/353599/merge#flatpak -- update

finally works! with the newer ostree version. Thanks.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 4, 2024
@JohnRTitor JohnRTitor self-assigned this Nov 4, 2024
@ofborg ofborg bot requested a review from copumpkin November 4, 2024 20:06
amarshall
amarshall approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@amarshall amarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirm this builds and fixes flatpak failing, see also flatpak/flatpak#5950

@JohnRTitor JohnRTitor merged commit 7695a1e into NixOS:master Nov 5, 2024
40 of 41 checks passed
@TheMuso TheMuso mentioned this pull request Nov 5, 2024
Closed
13 tasks
@rawkode rawkode deleted the chore/update-ostree branch November 6, 2024 09:49
@elias-online
Copy link

I think this needs to be backported to the 24.05 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnRTitor JohnRTitor JohnRTitor approved these changes

@amarshall amarshall amarshall approved these changes

@danielbarter danielbarter Awaiting requested review from danielbarter

@copumpkin copumpkin Awaiting requested review from copumpkin

Assignees

@JohnRTitor JohnRTitor

Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rawkode @elias-online @amarshall @JohnRTitor @wegank