nixos/godns: init module #348290
Open
nixos/godns: init module #348290
+65
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
michaelvanstraten
force-pushed
the
add-godns-service
branch
from
62ee801
to
309ce77
Compare
NixOSInfra
added
the
12. first-time contribution
michaelvanstraten
force-pushed
the
add-godns-service
branch
from
309ce77
to
375e072
Compare
ofborg
bot
added
10.rebuild-darwin: 0
michaelvanstraten
force-pushed
the
add-godns-service
branch
from
375e072
to
625eb98
Compare
Comment on lines
+25
to
+29
| configPath = mkOption { | ||
| type = types.path; | ||
| description = "Path to the configuration file for godns."; | ||
| example = "/etc/godns/config.json"; | ||
| }; |
There was a problem hiding this comment.
We should allow writing that with nixos options
There was a problem hiding this comment.
Got it, I would for now prefer to have this untyped, so just a generic Attribute set holding the config. Is that okay?
There was a problem hiding this comment.
Sorry @SuperSandro2000 do you mean a NixOS option specifying all available options in the configuration or a generic Attribute set or a string?
michaelvanstraten
force-pushed
the
add-godns-service
branch
3 times, most recently
from
cd5e5ba
to
bd611bc
Compare
Initial implementation of the GoDNS service module. This module allows users to enable and configure the GoDNS service on their NixOS system. It includes options for specifying the GoDNS package and the path to the configuration file.
michaelvanstraten
force-pushed
the
add-godns-service
branch
from
bd611bc
to
54f25d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new NixOS module for the GoDNS service, which allows users to enable and configure the GoDNS service on their NixOS system.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.