vimPlugins: add nvimRequireChecks #347398
Open
+735
−358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khaneliman
force-pushed
the
nvimrequirecheck
branch
2 times, most recently
from
c7f3e36
to
f48a6f6
Compare
khaneliman
changed the title
khaneliman
force-pushed
the
nvimrequirecheck
branch
from
f48a6f6
to
714c7e3
Compare
ofborg
bot
added
10.rebuild-darwin: 101-500
10.rebuild-linux: 101-500
8.has: clean-up
labels
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wanted to catch plugin runtime and dependency issues in build process so we don't have to find them downstream in other locations. This is an easy first step to doing that. Started off adding checks to existing overridden plugins and correcting dependency errors found during those tests. There were a few that will fail still until #342240 hits master and then we can revisit enabling them.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.