cvs: use ssh instead of rsh.

[joshuakb2]

If no ssh executable can be found during the configure phase, CVS defaults to using rsh for remote connections instead. This seems undesirable in 2024.

Things done

• Added the openssh package to the build inputs so that the ssh executable is found by configure.

• Built on platform(s)

  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin

• Tested, as applicable:

  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages

• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage

• Tested basic functionality of all binary files (usually in ./result/bin/)

• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module

• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[AndersonTorres]

buildInputs?

[joshuakb2]

buildInputs?

Yes, it seems that if configure doesn't find an ssh executable in $PATH during the build, the built cvs executable won't even try to use ssh even though that's the intended behavior according to the release notes, and it's the behavior on every other Linux distro I've used.

However, it occurs to me now that maybe configure can't tell the difference between a real ssh executable and a fake ssh executable that exists only during the configuration step. The cvs executable seems to run whatever ssh is in the environment at runtime anyway. So maybe there's no need to depend on the real openssh package to fix this.

[joshuakb2]

Sure enough, it works fine with a fake SSH executable present during the build. So I think I'll amend my pull request to not use the openssh package, it's unnecessary.