Onlyoffice - new boolean: allow LAN/localhost connections #347209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems nothing blocking this from release-24.05 |
SuperSandro2000
requested changes
Oct 8, 2024
| sed -i 's/"allowMetaIPAddress": false/"allowMetaIPAddress": true/' /run/onlyoffice/config/default.json | ||
| ''} | ||
|
|
||
|
|
||
| # Allow members of the onlyoffice group to serve files under /var/lib/onlyoffice/documentserver/App_Data | ||
| chmod g+x /var/lib/onlyoffice/documentserver | ||
|
|
There was a problem hiding this comment.
I imagine we want to do the following:
- add a freeform json type option
- use pkgs.writeJSON on it
- merge it into the default.json in line 263
Can you do that? Thanks!
There was a problem hiding this comment.
I do not think I have the knowledge to do a free-form JSON type but I did replace my commits with a new one that just uses the boolean and jq as you requested
|
Please follow the contributing guide when naming your commits. |
|
@SuperSandro2000 will you accept this limited PR that does not introduce a free form json input (which I don't know how to do) but just adds the bool option into the existing jq structure? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Onlyoffice (which Nextcloud can use for the office-app suite) does not allow local connections.
Resolves #317225
per OnlyOffice Forums
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.
@SuperSandro2000