pakcs: 3.6.0 -> 3.7.2, build on ghc9 #346268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I’d prefer not vendoring the patch but fetching it with fetchpatch from a PR against upstream, but its your decision. |
|
I seriously recommend that we activate the pakcs job in pkgs/top-level/release-haskell.nix (uncomment line 335) so that we notice when one of the haskell-updates breaks pakcs again. |
| inherit src; | ||
| postUnpack = "sourceRoot+=/frontend"; | ||
|
|
||
| # NOTE: We cannot use `appendPatches` because it conflicts with `overrideCabal` |
There was a problem hiding this comment.
appendPatches should do the same as you have written out here. Any specific problems?
There was a problem hiding this comment.
Oh ok haskell.lib.compose.appendPatch works, I've tried haskell.lib.appendPatch before and it doesn't compose well with overrideCabal I guess
error:
… while calling the 'derivationStrict' builtin
at <nix/derivation-internal.nix>:34:12:
33|
34| strict = derivationStrict drvAttrs;
| ^
35|
… while evaluating derivation 'pakcs-3.7.2'
whose name attribute is located at /home/t4ccer/repos/github/NixOS/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:336:7
… while evaluating attribute 'makeFlags' of derivation 'pakcs-3.7.2'
at /home/t4ccer/repos/github/NixOS/nixpkgs/pkgs/development/compilers/pakcs/default.nix:43:3:
42|
43| makeFlags = [
| ^
44| "CURRYFRONTEND=${curry-frontend}/bin/curry-frontend"
(stack trace truncated; use '--show-trace' to show the full, detailed trace)
error: attribute 'override' missing
at /home/t4ccer/repos/github/NixOS/nixpkgs/pkgs/development/haskell-modules/lib/compose.nix:38:28:
37| */
38| overrideCabal = f: drv: (drv.override (args: args // {
| ^
39| mkDerivation = drv: (args.mkDerivation drv).override f;
```
There was a problem hiding this comment.
I've pushed this change, doesn't even trigger a rebuild
sternenseemann
approved these changes
Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
version bump and switch to ghc9
cc #346214
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.