Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport release-24.05] dbeaver-bin: add webkitgkt and glib-networking for webbrowser support #339947

Open
wants to merge 12 commits into
base: release-24.05
Choose a base branch
from
Open

[Backport release-24.05] dbeaver-bin: add webkitgkt and glib-networking for webbrowser support #339947

wants to merge 12 commits into from

Conversation

gepbird
Copy link
Contributor

@gepbird gepbird commented Sep 6, 2024

Description of changes

Backport of #336742 and its dependencies.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@gepbird
Copy link
Contributor Author

gepbird commented Sep 22, 2024

@ofborg eval

@gepbird gepbird mentioned this pull request Sep 22, 2024
Closed
13 tasks
@yzx9 @gepbird
maintainers: add yzx9
36aeb9c 
(cherry picked from commit efb8281)
@gepbird
Copy link
Contributor Author

gepbird commented Sep 22, 2024

Fixed the eval error by adding yzx9's maintainer commit, and formatted the maintainer-list file in later commit.

gepbird and others added 11 commits September 22, 2024 09:55
@gepbird
maintainers: format
97156e7
@yzx9 @gepbird
dbeaver-bin: add darwin support
973ada2 
(cherry picked from commit 224aa24)
@gepbird
dbeaver-bin: 24.0.5 -> 24.1.0
e13b0cc 
(cherry picked from commit cd0de86)
@gepbird
dbeaver-bin: change order of attrs
1051eee 
(cherry picked from commit 41f0db2)
@r-ryantm @gepbird
dbeaver-bin: 24.1.0 -> 24.1.1
64c1f0b 
(cherry picked from commit a20ba70)
@21CSM @gepbird
dbeaver-bin: 24.1.1 -> 24.1.2
6e945b7 
dbeaver-bin: Update hashes
(cherry picked from commit 8d7e6c6)
@gepbird
dbeaver-bin: 24.1.2 -> 24.1.3
3cc92b4 
(cherry picked from commit 662d615)
@r-ryantm @gepbird
dbeaver-bin: 24.1.3 -> 24.1.4
a0aa3de 
(cherry picked from commit cbe511a)
@mausch @gepbird
dbeaver-bin: fix crash at startup
be93dd4 
Fixes NixOS#330889

(cherry picked from commit da69826)
@mkg20001 @gepbird
dbeaver-bin: 24.1.4 -> 24.1.5
7d0bcfa 
(cherry picked from commit 83c6f0d)
@gepbird
dbeaver-bin: add webkitgkt and glib-networking for webbrowser support
a728cc9 
(cherry picked from commit 9c9405d)
@ofborg ofborg bot requested review from mkg20001 and yzx9 September 22, 2024 08:50
yzx9
yzx9 approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@yzx9 yzx9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gepbird Thank you for your careful review and backporting the maintainer commit!

1 package built:
dbeaver-bin

Result of nixpkgs-review pr 339947 run on aarch64-darwin 1

1 package built:
  • dbeaver-bin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yzx9 yzx9 yzx9 approved these changes

@mkg20001 mkg20001 Awaiting requested review from mkg20001

Assignees
No one assigned
Labels
8.has: clean-up 8.has: maintainer-list (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer 12.approvals: 1 12.approved-by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gepbird @yzx9 @wegank @r-ryantm @21CSM @mausch @mkg20001