Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kando: init at 1.4.0 #337555

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

kando: init at 1.4.0 #337555

wants to merge 1 commit into from

Conversation

TomaSajt
Copy link
Contributor

@TomaSajt TomaSajt commented Aug 26, 2024

Description of changes

Closes #297267

This PR adds 1 package: kando

The build process uses cmake-js which wants to fetch the node headers. I patched that out, and instead I specified the headers manually using NIX_CFLAGS_COMPILE.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@KingKrouch
Copy link

I tested this package out via the .tar.gz in the issue ticket for Kando, and I can confirm that this package works fine, at least from my experience. I'm running a x86_64 install of NixOS.

@dasj19
Copy link
Contributor

dasj19 commented Sep 9, 2024

Tested briefly on GNOME. Had to install gnomeExtensions.kando-integration first.
I am first time kando user and I do not know what to expect. However I found out that it kinda keeps selecting "Clipboard" automatically after Ctrl+Space.

There are also some messages in the console output:

Running on Linux (GNOME on wayland).
Loading settings from /home/daniel/.config/kando/config.json
Loading settings from /home/daniel/.config/kando/menus.json
[93944:0909/221028.882694:ERROR:atom_cache.cc(229)] Add _NET_WM_WINDOW_TYPE_DOCK to kAtomsToCache
did not find extension DRI_Mesa version 2
did not find extension DRI_IMAGE_DRIVER version 2
failed to bind extensions
did not find extension DRI_Mesa version 2
did not find extension DRI_IMAGE_DRIVER version 2
failed to bind extensions
did not find extension DRI_Mesa version 2
failed to bind extensions
Kando 1.3.0 is ready.
Successfully loaded Kando's renderer process.
[93982:0909/221045.463697:ERROR:gl_surface_presentation_helper.cc(260)] GetVSyncParametersIfAvailable() failed for 1 times!
[93982:0909/221045.468060:ERROR:gl_surface_presentation_helper.cc(260)] GetVSyncParametersIfAvailable() failed for 2 times!
You are running the latest version of Kando.
[93982:0909/221054.030865:ERROR:gl_surface_presentation_helper.cc(260)] GetVSyncParametersIfAvailable() failed for 3 times!

@Blezz-tech
Copy link

Tried to build a kendo in the current unstable channel

I failed.

Here's the log: https://gist.github.com/Blezz-tech/1de6a2fe8654ad16eb99b692c5d32574

Use this command for get log

nix log /nix/store/asx4wmxjmmjqvr7jmqnzqsdkaggdsac9-kando-1.3.0.drv > log

log.txt

@Blezz-tech
Copy link

Blezz-tech commented Sep 16, 2024

Kando is released in 1.4.0

https://github.com/kando-menu/kando/releases/tag/v1.4.0

@Blezz-tech
Copy link

I was able to build Kando by adding wayland-scanner in nativeBuildInputs, buildInputs

@TomaSajt
Copy link
Contributor Author

I believe I saw a PR recently that reorganized how wayland-scanner is packaged (iirc it's no longer part of the wayland pacakage)

I'll swap it out when I get back home

@TomaSajt TomaSajt changed the title kando: init at 1.3.0 kando: init at 1.4.0 Sep 16, 2024
Copy link
Contributor

@dasj19 dasj19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried kando in my Gnome 46 and X11 vs Wayland.
As mentioned earlier after I run kando and firstly select one of its buttons, it keeps selecting one of the buttons after triggering the kando menu with Ctrl+Space. Instead of centering kando at the tip of the cursor, it has the cursor on some other button hence selecting it.

Note that this happens only on Wayland.

I do not know if it is a packaging issue or an upstream issue, but here are the output I get:

In X11:

Running on Linux (GNOME on x11).
Loading settings from /home/daniel/.config/kando/config.json
Loading settings from /home/daniel/.config/kando/menus.json
[41143:0921/143048.906245:ERROR:atom_cache.cc(229)] Add _NET_WM_WINDOW_TYPE_DOCK to kAtomsToCache
Kando 1.4.0 is ready.
Successfully loaded Kando's renderer process.
You are running the latest version of Kando.

In Wayland:

Running on Linux (GNOME on wayland).
Loading settings from /home/daniel/.config/kando/config.json
Loading settings from /home/daniel/.config/kando/menus.json
[60410:0921/143840.907569:ERROR:atom_cache.cc(229)] Add _NET_WM_WINDOW_TYPE_DOCK to kAtomsToCache
Kando 1.4.0 is ready.
Successfully loaded Kando's renderer process.
[60446:0921/143842.744036:ERROR:gl_surface_presentation_helper.cc(260)] GetVSyncParametersIfAvailable() failed for 1 times!
[60446:0921/143842.755449:ERROR:gl_surface_presentation_helper.cc(260)] GetVSyncParametersIfAvailable() failed for 2 times!
You are running the latest version of Kando.
[60446:0921/143844.440516:ERROR:gl_surface_presentation_helper.cc(260)] GetVSyncParametersIfAvailable() failed for 3 times!

I would like it working in Wayland but it has issues... I will wait for Gnome 47 to land and do a new round of testing.

@Blezz-tech
Copy link

I use Kando in KDE Plasma (Wayland)

I get some errors in the console, but everything seems to be working fine

~ ❯ kando
Running on Linux (KDE on wayland).
Loading settings from /home/jenya/.config/kando/config.json
Loading settings from /home/jenya/.config/kando/menus.json
[86749:0921/160330.211353:ERROR:atom_cache.cc(229)] Add _NET_WM_WINDOW_TYPE_TOOLBAR to kAtomsToCache
Kando 1.4.0 is ready.
Successfully loaded Kando's renderer process.
[86783:0921/160332.598393:ERROR:gl_surface_presentation_helper.cc(260)] GetVSyncParametersIfAvailable() failed for 1 times!
[86783:0921/160332.604663:ERROR:gl_surface_presentation_helper.cc(260)] GetVSyncParametersIfAvailable() failed for 2 times!
You are running the latest version of Kando.
[86783:0921/160338.075179:ERROR:gl_surface_presentation_helper.cc(260)] GetVSyncParametersIfAvailable() failed for 3 times!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: kando 🥧 The Cross-Platform Pie Menu.
4 participants