hpp-fcl: add missing dependency #337549
Merged
hpp-fcl: add missing dependency #337549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix:
```python
>>> import hppfcl
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/nix/store/dfnl1p604453r5rc29h3bnr4vjn811lj-hpp-fcl-3.0.0-pre/lib/python3.11/site-packages/hppfcl/__init__.py", line 35, in <module>
from .hppfcl import *
ImportError: libz.so.1: cannot open shared object file: No such file or directory
```
|
Result of 17 packages built:
|
|
Result of 17 packages built:
|
drupol
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
I noticed that, when used alone, hpp-fcl python bindings lack zlib:
Here is a fix, and also fix the import test to ensure this won't happen again.
While here, clean the package a bit.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.