widevine-cdm: add aarch64 support #337261

dxwil · 2024-08-25T14:56:48Z

Description of changes

Adds support for arm64 widevine using code from widevine-installer. The package builds and outputs the relevant files in the same locations as the x64 version, although I cannot test it because I don't know how to make chromium.enableWideVine select a local version, it tries to install the x64 one (please help me on this one :).

There are also some things I would like input on from someone else:

Versioning between the two builds. Currently arm is using an older version, it's probably a good idea to make them the same, but without being able to test, I can't do that, because I don't know if newer versions exist and can be successfully patched for arm. List of chromeos images containing arm64 widevine here.
Firefox support. Shouldn't be hard to implement if we come up with a system. Chromium has the enableWideVine flag that as I'm aware does not exist for Firefox. All that Firefox needs are some options as well as one env variable, refer to this. I could build this into the package but that would mean installing the package would configure Firefox automatically, which is different from the behavior that exists with Chromium (where enableWideVine needs to be set).

Edit: after some googling I see that Firefox drm works out of the box for x64, but for arm the changes linked above are still necessary.

Edit 2: What I don't understand is why Firefox doesn't need a seperate flag for widevine like chromium, is it because Firefox only installs widevine if drm is explicitly enabled and chromium auto installs it on launch? Could it also have something to do with licenses, why isn't Firefox unfree when it has widevine and chromium is?

Things done

Add a 👍 reaction to pull requests you find important.

nixos-discourse · 2024-08-26T19:14:55Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/widevine-aarch64-input-needed/51209/1

RossComputerGuy · 2024-08-26T19:34:26Z

Cool, thank you for putting in the effort. I was meaning to get to this myself but just haven't found the time. I'll review and test this tonight.

dxwil · 2024-08-26T20:16:36Z

pkgs/applications/networking/browsers/misc/widevine-cdm.nix


 runHook postInstall
 '';

+# Accoring to widevine-installer: "Hack because Chromium hardcodes a check for this right now..."


Cannot verify without being able to test

RossComputerGuy · 2024-08-27T01:44:31Z

Result of nixpkgs-review pr 337261 run on aarch64-linux 1

1 package built:

widevine-cdm

RossComputerGuy

Good start, got some changes.

pkgs/applications/networking/browsers/misc/widevine-cdm.nix

RossComputerGuy · 2024-08-27T01:54:20Z

pkgs/applications/networking/browsers/misc/widevine-cdm.nix

+ '';
+ } else null;
+
+ src = if stdenv.isAarch64 then fetchurl {


Suggested change

src = if stdenv.isAarch64 then fetchurl {

src = fetchurl (if stdenv.isAarch64 then {

url = "https://commondatastorage.googleapis.com/chromeos-localmirror/distfiles/chromeos-lacros-arm64-squash-zstd-${lacrosVersion}";

hash = "sha256-OKV8w5da9oZ1oSGbADVPCIkP9Y0MVLaQ3PXS3ZBLFXY=";

} else {

url = "https://dl.google.com/widevine-cdm/${version}-linux-x64.zip";

hash = "sha256-lGTrSzUk5FluH1o4E/9atLIabEpco3C3gZw+y6H6LJo=";

stripRoot = false;

});

from my testing fetchurl doesn't know how to unpack a zip file without specifying an unpackPhase

pkgs/applications/networking/browsers/misc/widevine-cdm.nix

dxwil · 2024-08-27T07:42:19Z

I messed up something with the commits... now the add maintainers one is called the same as the other ones

dxwil · 2024-08-27T15:00:11Z

@RossComputerGuy do you know how I can get enableWideVine in chromium to select a local package so I can test

emilylange · 2024-08-27T19:06:55Z

Unsure if I understand the question correctly, but to get chromium with enableWideVine = true from your local nixpkgs checkout, you can use

NIXPKGS_ALLOW_UNFREE=1 nix-build -E "(import ./. {}).chromium.override { enableWideVine = true; }"

dxwil · 2024-08-27T21:21:52Z

Unsure if I understand the question correctly, but to get chromium with enableWideVine = true from your local nixpkgs checkout, you can use
NIXPKGS_ALLOW_UNFREE=1 nix-build -E "(import ./. {}).chromium.override { enableWideVine = true; }"

This is the part that's responsible for enabling widevine in chromium, it would fetch ${widevine-cdm} from upstream. How can I make it use a locally built version of widevine because upstream does not support aarch64, and would that also require for me to rebuild chromium?

RossComputerGuy · 2024-08-28T03:28:20Z

it would fetch ${widevine-cdm} from upstream.

Where does it do that?

How can I make it use a locally built version of widevine because upstream does not support aarch64

You can run that command in your branch.

and would that also require for me to rebuild chromium?

Any dependency or derivation changes to Chromium would cause a rebuild.

RossComputerGuy · 2024-08-28T03:47:34Z

That command works and took very little time on my own hardware (note the time nom-build outputted was because I had built it before).

RossComputerGuy · 2024-08-28T03:50:35Z

I did a quick look at Tidal HiFi and we'll have to build from source instead of the prebuilt x86_64 binary. However, I did find this issue when looking into their issues. castlabs/electron-releases#23 (comment)

The CDM contains video decoders, and thus requires MPEG-LA licensing. As long as the CDM is hosted by Google and dynamically installed from their servers, the license they have is enough. Hosting and/or bundling the CDM outside of Google could incur license requirements, and thus have legal consequences.

I am not 100% certain if this could cause us any legal issues. Just bringing this up so more knowledable individuals could say whether this is a problem or not.

dxwil · 2024-08-28T08:57:16Z

I did a quick look at Tidal HiFi and we'll have to build from source instead of the prebuilt x86_64 binary.

Could u elaborate?

dxwil · 2024-08-28T09:02:38Z

I am not 100% certain if this could cause us any legal issues. Just bringing this up so more knowledable individuals could say whether this is a problem or not.

Comparing to the x64 version, we're only applying one patch, that's the whole difference. Is the patch something that could bring trouble?

RossComputerGuy · 2024-08-29T15:56:09Z

Could u elaborate?

Can't easily run x64 binaries on arm64

Comparing to the x64 version, we're only applying one patch, that's the whole difference.

Well, it's to a proprietary executable. That executable contains video decoders which are proprietary as well. As long as the binary isn't redistributed there doesn't seem to be any legal concerns.

dxwil · 2024-08-29T16:06:58Z

I tried tidal-hifi and it obviously doesn't launch because it's only downloading the x64 binaries, I don't know why the nix package shows support for aarch64, it shouldn't in the first place.

Would you say the chrome install as done now is figured out and good enough to merge? I would still like to come up with something for Firefox as well as proper versioning though.

RossComputerGuy · 2024-08-29T16:09:07Z

Would you say the chrome install as done now is figured out and good enough to merge?

Yeah, Chrome is good enough.

I would still like to come up with something for Firefox as well as proper versioning though.

I think we should bring the Firefox maintainers into the discussion. Maybe after merge, we create an issue and ping them so it doesn't clutter up this PR.

dxwil · 2024-08-29T16:15:37Z

Would you say the chrome install as done now is figured out and good enough to merge?

Yeah, Chrome is good enough.

I would still like to come up with something for Firefox as well as proper versioning though.

I think we should bring the Firefox maintainers into the discussion. Maybe after merge, we create an issue and ping them so it doesn't clutter up this PR.

Yeah good idea, so anything else from me or can you merge?

RossComputerGuy

LGTM

dxwil · 2024-08-29T16:38:33Z

PS. We cannot build tidal hifi from source because it uses Castlab's electron with widevine built-in which does not support aarch64. So I'll just open a PR to remove advertised aarch64 support.

dxwil · 2024-08-29T20:22:18Z

That command works and took very little time on my own hardware (note the time nom-build outputted was because I had built it before).

Out of interest, what CPU are you using. I'm running the same command right now and it's been building for an hour and from the task number it looks like it's gonna take another 3 minimum. I'm on an Apple m1.

winterqt · 2024-08-29T20:32:36Z

pkgs/applications/networking/browsers/misc/widevine-cdm.nix

+ buildInputs = [ squashfsTools curl python3 ];
+
+ unpackPhase = if stdenv.isAarch64 then ''
+ curl -# -o lacros.squashfs "file://$src"


Why did you copy this from upstream? Just copy the file...?

Could you elaborate, I don't think I understand? unsquashfs wouldn't work without renaming using curl like widevine-installer does, but I only tried a few times, maybe it makes sense to figure this part out and remove curl from the buildInputs if that's what you mean.

curl in this case is a glorified copy or symlink. It makes sense to use it upstream because they're downloading from a URL. Please try cp or lning the file to see if that works, it should.

K900 · 2024-08-29T20:44:35Z

I see code copy-pasted without understanding from Asahi, I see comments marked as resolved without being addressed, this is not the kind of change we want to have. Reverting in #338262, please open a new PR and iterate.

@dxwil

Credit to @dxwil for the original attempt in NixOS#337261, this is a reattempt at adding aarch64-linux support to Widevine CDM based on how Asahi Linux deals with it. Signed-off-by: Tristan Ross <[email protected]>

@dxwil

Credit to @dxwil for the original attempt in NixOS#337261, this is a reattempt at adding aarch64-linux support to Widevine CDM based on how Asahi Linux deals with it. Signed-off-by: Tristan Ross <[email protected]>

@dxwil

Credit to @dxwil for the original attempt in NixOS#337261, this is a reattempt at adding aarch64-linux support to Widevine CDM based on how Asahi Linux deals with it. Signed-off-by: Tristan Ross <[email protected]>

dxwil force-pushed the widevine-cdm-arm64 branch 4 times, most recently from 4913908 to 40db96d Compare August 25, 2024 15:02

This was referenced Aug 25, 2024

Package request: widevine-cdm arm64 #220828

Open

chromium: add widevine support on aarch64 #251085

Closed

Enable Widevine support tpwrules/nixos-apple-silicon#145

Open

widevine-cdm: add aarch64 support

0ef71c7

dxwil force-pushed the widevine-cdm-arm64 branch from 40db96d to 0ef71c7 Compare August 25, 2024 15:46

widevine-cdm: add aarch64 support

db90914

github-actions bot added the 8.has: maintainer-list (update) label Aug 25, 2024

ofborg bot added 8.has: package (new) 11.by: package-maintainer 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Aug 25, 2024

RossComputerGuy self-assigned this Aug 26, 2024

dxwil commented Aug 26, 2024

View reviewed changes

RossComputerGuy requested changes Aug 27, 2024

View reviewed changes

dxwil force-pushed the widevine-cdm-arm64 branch 3 times, most recently from 5921521 to 9a83b97 Compare August 27, 2024 07:40

dxwil force-pushed the widevine-cdm-arm64 branch 3 times, most recently from 27af374 to 9bf71ba Compare August 27, 2024 08:34

widevine-cdm: add aarch64 support

e332e2c

dxwil force-pushed the widevine-cdm-arm64 branch from 9bf71ba to e332e2c Compare August 27, 2024 14:58

RossComputerGuy approved these changes Aug 29, 2024

View reviewed changes

RossComputerGuy merged commit 83ad471 into NixOS:master Aug 29, 2024
26 of 27 checks passed

dxwil deleted the widevine-cdm-arm64 branch August 29, 2024 16:45

winterqt reviewed Aug 29, 2024

View reviewed changes

K900 mentioned this pull request Aug 29, 2024

Revert "widevine-cdm: add aarch64 support" #338262

Merged

RossComputerGuy mentioned this pull request Sep 21, 2024

widevine-cdm: add aarch64 support #343393

Open

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

widevine-cdm: add aarch64 support #337261

widevine-cdm: add aarch64 support #337261

dxwil commented Aug 25, 2024 •

edited

Loading

nixos-discourse commented Aug 26, 2024

RossComputerGuy commented Aug 26, 2024

dxwil Aug 26, 2024

RossComputerGuy commented Aug 27, 2024

RossComputerGuy left a comment

RossComputerGuy Aug 27, 2024

dxwil Aug 27, 2024

dxwil commented Aug 27, 2024

dxwil commented Aug 27, 2024

emilylange commented Aug 27, 2024 •

edited

Loading

dxwil commented Aug 27, 2024 •

edited

Loading

RossComputerGuy commented Aug 28, 2024

RossComputerGuy commented Aug 28, 2024

RossComputerGuy commented Aug 28, 2024

dxwil commented Aug 28, 2024

dxwil commented Aug 28, 2024

RossComputerGuy commented Aug 29, 2024

dxwil commented Aug 29, 2024

RossComputerGuy commented Aug 29, 2024

dxwil commented Aug 29, 2024 •

edited

Loading

RossComputerGuy left a comment

dxwil commented Aug 29, 2024

dxwil commented Aug 29, 2024

winterqt Aug 29, 2024

dxwil Aug 29, 2024 •

edited

Loading

winterqt Aug 29, 2024

K900 commented Aug 29, 2024

- src = if stdenv.isAarch64 then fetchurl {
+ src = fetchurl (if stdenv.isAarch64 then {
+ url = "https://commondatastorage.googleapis.com/chromeos-localmirror/distfiles/chromeos-lacros-arm64-squash-zstd-${lacrosVersion}";
+ hash = "sha256-OKV8w5da9oZ1oSGbADVPCIkP9Y0MVLaQ3PXS3ZBLFXY=";
+ } else {
+ url = "https://dl.google.com/widevine-cdm/${version}-linux-x64.zip";
+ hash = "sha256-lGTrSzUk5FluH1o4E/9atLIabEpco3C3gZw+y6H6LJo=";
+ stripRoot = false;
+ });

widevine-cdm: add aarch64 support #337261

widevine-cdm: add aarch64 support #337261

Conversation

dxwil commented Aug 25, 2024 • edited Loading

Description of changes

Things done

nixos-discourse commented Aug 26, 2024

RossComputerGuy commented Aug 26, 2024

dxwil Aug 26, 2024

Choose a reason for hiding this comment

RossComputerGuy commented Aug 27, 2024

RossComputerGuy left a comment

Choose a reason for hiding this comment

RossComputerGuy Aug 27, 2024

Choose a reason for hiding this comment

dxwil Aug 27, 2024

Choose a reason for hiding this comment

dxwil commented Aug 27, 2024

dxwil commented Aug 27, 2024

emilylange commented Aug 27, 2024 • edited Loading

dxwil commented Aug 27, 2024 • edited Loading

RossComputerGuy commented Aug 28, 2024

RossComputerGuy commented Aug 28, 2024

RossComputerGuy commented Aug 28, 2024

dxwil commented Aug 28, 2024

dxwil commented Aug 28, 2024

RossComputerGuy commented Aug 29, 2024

dxwil commented Aug 29, 2024

RossComputerGuy commented Aug 29, 2024

dxwil commented Aug 29, 2024 • edited Loading

RossComputerGuy left a comment

Choose a reason for hiding this comment

dxwil commented Aug 29, 2024

dxwil commented Aug 29, 2024

winterqt Aug 29, 2024

Choose a reason for hiding this comment

dxwil Aug 29, 2024 • edited Loading

Choose a reason for hiding this comment

winterqt Aug 29, 2024

Choose a reason for hiding this comment

K900 commented Aug 29, 2024

dxwil commented Aug 25, 2024 •

edited

Loading

emilylange commented Aug 27, 2024 •

edited

Loading

dxwil commented Aug 27, 2024 •

edited

Loading

dxwil commented Aug 29, 2024 •

edited

Loading

dxwil Aug 29, 2024 •

edited

Loading