Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.openllm: 0.5.7 -> 0.6.10; python312Packages.bentoml: 1.2.18 -> 1.3.3 #336924

Merged
merged 5 commits into from
Aug 25, 2024

Conversation

natsukium
Copy link
Member

Description of changes

Diff: bentoml/OpenLLM@refs/tags/v0.5.7...v0.6.10
Changelog: https://github.com/bentoml/OpenLLM/releases/tag/v0.6.10

Diff: bentoml/BentoML@refs/tags/v1.2.18...v1.3.3
Changelog: https://github.com/bentoml/BentoML/releases/tag/v1.3.3

also, remove openllm-core and openllm-client since the project's philosophy has changed.
https://github.com/bentoml/OpenLLM/releases/tag/v0.6.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@natsukium
Copy link
Member Author

natsukium commented Aug 24, 2024

Result of nixpkgs-review pr 336924 at 9655d45 run on x86_64-linux 1

3 packages marked as broken and skipped:
  • openllm
  • python311Packages.bentoml
  • python312Packages.bentoml

Result of nixpkgs-review pr 336924 at 77707d80 run on aarch64-darwin 1


Result of nixpkgs-review pr 336924 at 77707d80 run on x86_64-linux 1

2 packages marked as broken and skipped:
  • python311Packages.bentoml
  • python312Packages.bentoml
1 package built successfully:
  • openllm

@natsukium
Copy link
Member Author

openllm will be fixed by #336903


pythonImportsCheck = [ "openllm" ];

meta = with lib; {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we add meta.mainProgram set to openllm ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thanks.

openllm-client has been removed, since it is abandoned due to a change
in philosophy
openllm-core has been removed, since it is abandoned due to a change in
philosophy
@natsukium natsukium merged commit c15b836 into NixOS:master Aug 25, 2024
24 of 26 checks passed
@natsukium natsukium deleted the openllm/update branch August 25, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants