[Backport release-24.05] lixVersions.lix_2_91: init #336617
Merged
+263
−205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This meant that pkgs.lix.passthru.tests.misc never evaluated. It should be noted that it seems like completely different test infrastructure is in use on master (25.11), or maybe it is just that the same test got renamed to nix-misc. Either way, this is busted.
This differs in two ways from master: - tests.misc uses the nixos test name used in 24.05 - the boost stuff rendered obsolete when NixOS#86131 was fixed is left intact, since it is not fixed in 24.05 This does *not* differ in the accidentally disabling LTO. That's fixed in the 2.91 commit. Seems to build on x86_64-linux. This commit is done so that we can more directly cherry-pick future lix versions from master by removing gratuitous divergences in the package that make maintenance annoying (it seems like master has experienced a round of nixfmt-rfc-style).
Original PR: NixOS#334269 This adds Lix 2.91.0 to nixpkgs and sets it as the default Lix release. This is compliant with the 24.05 stability policy because Lix 2.91 does not break any users (io_uring is already only partially available due to old kernels, nobody on github uses build-hook, and nix 2.3 is the oldest version of nix with security support). Blog post: https://lix.systems/blog/2024-08-12-lix-2.91-release/ Release notes: https://docs.lix.systems/manual/lix/stable/release-notes/rl-2.91.html Change-Id: I6960314bddceb7ab10e3cd6d9842d578f501fd76 Co-authored-by: Atemu <[email protected]> Co-authored-by: Yureka <[email protected]> Co-authored-by: getchoo <[email protected]> (cherry picked from commit 5b6d2fb)
|
(yes this is not a pure cherry pick. this is deliberate, i hopefully structured the commits to make reviewing it ok) |
|
can anyone review this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Original PR: #334269
This adds Lix 2.91.0 to nixpkgs and sets it as the default Lix release.
This is compliant with the 24.05 stability policy because Lix 2.91 does
not break any users (io_uring is already only partially available due to
old kernels, nobody on github uses build-hook, and nix 2.3 is the oldest
version of nix with security support).
Reviewer note: this is split into commits on purpose. I recommend an ignore-whitespace diff (?w=1 in url on github).
Blog post:
https://lix.systems/blog/2024-08-12-lix-2.91-release/
Release notes:
https://docs.lix.systems/manual/lix/stable/release-notes/rl-2.91.html
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.