Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.05] bitwarden-desktop: 2024.4.1 -> 2024.6.4 #335898

Merged
merged 5 commits into from
Aug 23, 2024

Conversation

dotlambda
Copy link
Member

Description of changes

fixes #335879
cc @iamstonecutter

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

amarshall and others added 5 commits August 19, 2024 13:09
- Update description to match bitwarden-cli
- Prefer `lib.getExe`

(cherry picked from commit e7521ac)
Otherwise nothing tells us we are using different than upstream. This
also checks anything else in the `package.json`’s `engines` spec, e.g.
npm version, which we might not care about but it’s compatible now so
it’s fine.

See https://docs.npmjs.com/cli/v10/using-npm/config#engine-strict

(cherry picked from commit d62d943)
@dotlambda dotlambda merged commit 29e8e22 into NixOS:release-24.05 Aug 23, 2024
23 of 25 checks passed
@dotlambda dotlambda deleted the bitwarden-desktop-24.05 branch August 23, 2024 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot sign in to Bitwarden-Desktop stable.
3 participants