-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python312Packages.mpi4py: 3.1.6 -> 3.1.6-unstable-2024-07-08; rewrite #327444
Conversation
I am not sure this is really broken. There are a lot of packages that use mpi4py and still work (with passing tests). |
@markuskowa I iterated the direct reverse dependencies of mpi4py and here's what I learned:
Besides the above, all packages that now don't depend on mpi4py build fine. Once ofborg finishes evaluation I will run |
Result of 18 packages marked as broken and skipped:
15 packages built:
|
Marked many packages as broken to make nixpkgs-review easier and cleaner. All of these are already broken for a while according to |
Here is finally my nixpkgs-review build: Result of 190 packages marked as broken and skipped:
6 packages failed to build:
362 packages built:
|
Thanks @sheepforce for the Nixpkgs-review report :) I didn't manage to produce it myself.. I iterated once more the now broken packages and fixed some of them (including |
I've started another nixpkgs-review round, which is now running. |
Result of 178 packages marked as broken and skipped:
8 packages failed to build:
376 packages built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got the same results as in your nixpkgs-review. simple-dftd3 is broken due to an ASE update, not because of the changes in this PR.
These fail due to deprecated API calls Co-authored-by: Phillip <[email protected]>
Thanks for the thorough review @sheepforce . I fixed the comments as you suggested. Will merge when CI is green. |
So I tried to use
mpi4py
as a dependency for a certain Python package, and I encountered a segmentation fault (the details of it don't matter now). I then read the expression ofmpi4py
:https://github.com/NixOS/nixpkgs/blob/be6ca51c35ce13ea1b8365aa95946f3643b58db2/pkgs/development/python-modules/mpi4py/default.nix
And it is very weird! Since when do we need to run
setup.py
like that as if it's the dawn of Nixpkgs? Also, the build log reflects there's a build error which is ignored. Quoting part of the latest build log from Hydra:Description of changes
This PR packages mpi4py in 2024 standards, updates it so no errors appear in the build, and enables tests in h5py.
Things done
nix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.