Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pgadmin: fix build #326096

Closed
wants to merge 2 commits into from
Closed

pgadmin: fix build #326096

wants to merge 2 commits into from

Conversation

dotlambda
Copy link
Member

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

cc @zoechi


Add a 👍 reaction to pull requests you find important.

@superherointj
Copy link
Contributor

Result of nixpkgs-review pr 326096 run on x86_64-linux 1

12 packages built:
  • pgadmin4
  • pgadmin4-desktopmode
  • pgadmin4-desktopmode.dist
  • pgadmin4.dist
  • python311Packages.flask-mailman
  • python311Packages.flask-mailman.dist
  • python311Packages.flask-security-too
  • python311Packages.flask-security-too.dist
  • python312Packages.flask-mailman
  • python312Packages.flask-mailman.dist
  • python312Packages.flask-security-too
  • python312Packages.flask-security-too.dist

@gador
Copy link
Member

gador commented Jul 10, 2024

Please see #325181 (already fixed there)

@superherointj
Copy link
Contributor

superherointj commented Jul 10, 2024

Please see #325181 (already fixed there)

As the changes aren't exactly equal.

gador, can you integrate dotlambda changes, and add him as co-author (for those changes)?

dotlambda, is that good for you? [On yes, please review gador PR once he is done.]

@gador
Copy link
Member

gador commented Jul 10, 2024

Please see #325181 (already fixed there)

As the changes aren't exactly equal.

gador, can you integrate dotlambda changes, and add him as co-author (for those changes)?

dotlambda, is that good for you? [On yes, please review gador PR once he is done.]

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants