Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows/check-nix-format: add python modules #324367

Closed

Conversation

natsukium
Copy link
Member

Description of changes

We accepted nixfmt as a formatter for python-modules in #313628.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@natsukium
Copy link
Member Author

Looks like we need to format again.
I will wait until staging-next is merged into master to avoid unnecessary conflicts.

@infinisil
Copy link
Member

I'm trying to focus on #322537 right now, so that we have a generic solution for all parts of Nixpkgs, would be great to support that :D

@natsukium natsukium closed this Jul 27, 2024
@natsukium natsukium deleted the check-nix-format-for-python-packages branch July 27, 2024 02:25
@infinisil
Copy link
Member

Btw with #326407 merged now, we shouldn't have regressions anymore whenever we once format something :D

@natsukium
Copy link
Member Author

Yeah, thanks for your great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants