Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/stalwart-mail: package and configure webadmin #314820

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

onny
Copy link
Contributor

@onny onny commented May 26, 2024

Description of changes

Package and configure webadmin for Stalwart-Mail.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@onny
Copy link
Contributor Author

onny commented Jul 14, 2024

its working :)

image

@onny onny marked this pull request as ready for review July 14, 2024 15:03
@onny
Copy link
Contributor Author

onny commented Aug 20, 2024

@SuperSandro2000 i haven't managed to build it yet using tailwindcss or "trunk". both fail because of missing dependencies :(

@onny
Copy link
Contributor Author

onny commented Aug 25, 2024

looks like "trunk" is trying to fetch dependencies from crates.io during build time 👀

error: builder for '/nix/store/q51v2c128i57g7kknsa3d2gva3i2ccm4-stalwart-mail-0.1.10.drv' failed with exit code 134;
       last 10 log lines:
       > Executing cargoSetupPostPatchHook
       > Validating consistency between /build/source/Cargo.lock and /build/stalwart-mail-0.1.10-vendor.tar.gz/Cargo.lock
       > Finished cargoSetupPostPatchHook
       > Running phase: updateAutotoolsGnuConfigScriptsPhase
       > Running phase: configurePhase
       > Running phase: buildPhase
       > thread '<unnamed>' panicked at /build/trunk-0.20.3-vendor.tar.gz/crates_io_api/src/async_client.rs:136:14:
       > called `Result::unwrap()` on an `Err` value: reqwest::Error { kind: Builder, source: Os { code: 2, kind: NotFound, message: "No such file or directory" } }
       > note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
       > /nix/store/hix7sl0wxajb5aq14afjdvzc3w0i8b14-stdenv-linux/setup: line 1703:    52 Aborted                 (core dumped) trunk build --release
       For full logs, run 'nix log /nix/store/q51v2c128i57g7kknsa3d2gva3i2ccm4-stalwart-mail-0.1.10.drv'.

@onny
Copy link
Contributor Author

onny commented Aug 26, 2024

at least the trunk pre-build hook for tailwindcss is working now 😄 not sure about the rust cross compile thing

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also fix cross in another PR. If this works LGTM

pkgs/by-name/st/stalwart-mail/package.nix Outdated Show resolved Hide resolved
@onny onny force-pushed the stalwart-web branch 3 times, most recently from ad04904 to f1f7f79 Compare September 4, 2024 15:18
@onny onny marked this pull request as ready for review September 4, 2024 16:26
@onny
Copy link
Contributor Author

onny commented Sep 4, 2024

Managed to build it successfully 🥳 Not sure where the merge conflict comes from 👀

@onny
Copy link
Contributor Author

onny commented Sep 5, 2024

Okay resolved it, ready for review :)

@onny onny requested a review from Shawn8901 September 5, 2024 06:35
@happysalada happysalada merged commit fcc6387 into NixOS:master Sep 6, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants