Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elmPackages.elm-analyse: fix starting server #313750

Merged
merged 1 commit into from
May 29, 2024

Conversation

am-on
Copy link
Contributor

@am-on am-on commented May 22, 2024

Couldn't start elm-analyse server (elm-analyse -s) with previous node-watch version. See stil4m/elm-analyse#253 for more details about error.

Updated to the latest node-watch https://www.npmjs.com/package/node-watch.

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@am-on am-on changed the title elmPackages.elm-analyse: bump node-watch to 0.7.4 elmPackages.elm-analyse: fix starting server May 22, 2024
Couldn't start elm-analyse server (`elm-analyse -s`) with previous
node-watch version. See stil4m/elm-analyse#253
for more details.
@am-on
Copy link
Contributor Author

am-on commented May 29, 2024

@turboMaCk you seem to be the most active with PRs related to Elm. Could you please take a look at this PR? Thank you.

There's a similar PR #304198 updating more packages, but not node-watch that's causing issues with elm-analyse.

Copy link
Member

@turboMaCk turboMaCk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other PR contains regression - that's the reason why it's not merged yet.

I've confirmed that this PR works though so it can be merged.

@turboMaCk turboMaCk merged commit 574745b into NixOS:master May 29, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants