pgx_ulid: init at 0.1.5 #312398
pgx_ulid: init at 0.1.5 #312398
Conversation
ofborg
bot
added
8.has: package (new)
|
Version |
|
This PR seems stalled; is there anything I can do to help get it merged? |
|
What's blocking this from being merged? Who needs to approve? |
| src = fetchFromGitHub { | ||
| owner = "pksunkara"; | ||
| repo = "pgx_ulid"; | ||
| rev = "29a037e7e2dd8b18e4bb5e5ec4f9a6fe270e84bc"; |
There was a problem hiding this comment.
| rev = "29a037e7e2dd8b18e4bb5e5ec4f9a6fe270e84bc"; | |
| rev = "v${version}"; |
| maintainers = [ maintainers.renzo ]; | ||
| platforms = postgresql.meta.platforms; | ||
| license = licenses.mit; | ||
| broken = versionOlder postgresql.version "11"; |
There was a problem hiding this comment.
We don't need to mark versions as broken which are not part of nixpkgs anymore. The oldest one we currently have is 12, so:
| broken = versionOlder postgresql.version "11"; |
| doCheck = false; | ||
|
|
||
| meta = with lib; { | ||
| description = "A PostgreSQL extension to support ULID"; |
There was a problem hiding this comment.
There was a PR a while ago to remove all articles at the beginning of descriptions, so:
| description = "A PostgreSQL extension to support ULID"; | |
| description = "PostgreSQL extension to support ULID"; |
|
|
||
| meta = with lib; { | ||
| description = "A PostgreSQL extension to support ULID"; | ||
| homepage = "https://github.com/pksunkara/pgx_ulid"; |
There was a problem hiding this comment.
Please also add a changelog entry, e.g. to https://github.com/pksunkara/pgx_ulid/blob/v${version}/CHANGELOG.md
wegank
added
the
2.status: stale
|
FYI v0.2.0 has just recently released: |
stale
bot
removed
the
2.status: stale
|
As mentioned here, the build process needs to be updated. |
|
Minimal building example for the new version. Could not trick pgrx tests into using the already built extension with the running postgres instance. {
buildPgrxExtension,
fetchFromGitHub,
postgresql,
}:
buildPgrxExtension rec {
inherit postgresql;
pname = "pgx_ulid";
version = "0.2.0";
src = fetchFromGitHub {
owner = "pksunkara";
repo = "pgx_ulid";
tag = "v${version}";
hash = "sha256-VdLWwkUA0sVs5Z/Lyf5oTRhcHVzPmhgnYQhIM8MWJ0c=";
};
cargoHash = "sha256-Gn+SjzGaxnGKJYI9+WyE1+TzlF/2Ne43aKbXrSzfQKM=";
# Upstream renames the extension when packaging
# https://github.com/pksunkara/pgx_ulid/blob/084778c3e2af08d16ec5ec3ef4e8f345ba0daa33/.github/workflows/release.yml#L81
postInstall =
let
installDir = "$out/share/postgresql/extension";
in
''
mv ${installDir}/${pname}.control ${installDir}/ulid.control
mv ${installDir}/${pname}--${version}.sql ${installDir}/ulid--${version}.sql
'';
# pgrx tests try to install the extension into nix store
doCheck = false;
} |
I think it should move all |
|
@k0001 If you don't have time, I could pick up this package in a new PR as I am currently using it myself either way |
|
Superseded by #371463 |
Description of changes
Initial packaging of the
pgx_ulidextension for PostgreSQL.https://github.com/pksunkara/pgx_ulid
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.