-
-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[23.11] mbedtls_2: 2.28.7 -> 2.28.8, mbedtls: add patch for CVE-2024-28755 #303874
Merged
risicle
merged 2 commits into
NixOS:release-23.11
from
risicle:ris-mbedtls-CVEs-2024-04-r23.11
Apr 16, 2024
Merged
[23.11] mbedtls_2: 2.28.7 -> 2.28.8, mbedtls: add patch for CVE-2024-28755 #303874
risicle
merged 2 commits into
NixOS:release-23.11
from
risicle:ris-mbedtls-CVEs-2024-04-r23.11
Apr 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog: https://github.com/Mbed-TLS/mbedtls/releases/tag/v2.28.8 Fixes CVE-2024-28960 (cherry picked from commit 92f5f12)
raphaelr
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Result of nixpkgs-review pr 303874
run on x86_64-linux 1
1 package marked as broken and skipped:
- obs-studio-plugins.obs-hyperion
201 packages built:
- bctoolbox
- belcard
- belle-sip
- belr
- bzrtp
- dillo
- dillong
- dislocker
- dolphin-emu
- dolphin-emu-primehack
- gauche
- gaucheBootstrap
- hashlink
- haxe (haxe_4_2)
- haxePackages.format
- haxePackages.heaps
- haxePackages.hlopenal
- haxePackages.hlsdl
- hxcpp (haxePackages.hxcpp)
- haxePackages.hxcs
- haxePackages.hxjava
- haxePackages.hxnodejs_4
- haxe_4_0
- haxe_4_1
- hiawatha
- hyperion-ng
- imhex
- kodiPackages.libretro-2048
- kodiPackages.libretro-fuse
- kodiPackages.libretro-genplus
- kodiPackages.libretro-mgba
- kodiPackages.libretro-nestopia
- kodiPackages.libretro-snes9x
- ledfx
- ledfx.dist
- liblinphone
- libosmoabis
- libretro.atari800
- libretro.beetle-gba
- libretro.beetle-lynx
- libretro.beetle-ngp
- libretro.beetle-pce
- libretro.beetle-pce-fast
- libretro.beetle-pcfx
- libretro.beetle-psx
- libretro.beetle-psx-hw
- libretro.beetle-saturn
- libretro.beetle-supafaust
- libretro.beetle-supergrafx
- libretro.beetle-vb
- libretro.beetle-wswan
- libretro.blastem
- libretro.bluemsx
- libretro.bsnes
- libretro.bsnes-hd
- libretro.bsnes-mercury
- libretro.bsnes-mercury-balanced
- libretro.bsnes-mercury-performance
- libretro.citra
- libretro.desmume
- libretro.desmume2015
- libretro.dolphin
- libretro.dosbox
- libretro.dosbox-pure
- libretro.eightyone
- libretro.fbalpha2012
- libretro.fbneo
- libretro.fceumm
- libretro.flycast
- libretro.fmsx
- libretro.freeintv
- libretro.fuse
- libretro.gambatte
- libretro.genesis-plus-gx
- libretro.gpsp
- libretro.gw
- libretro.handy
- libretro.hatari
- libretro.mame
- libretro.mame2000
- libretro.mame2003
- libretro.mame2003-plus
- libretro.mame2010
- libretro.mame2015
- libretro.mame2016
- libretro.melonds
- libretro.mesen
- libretro.mesen-s
- libretro.meteor
- libretro.mgba
- libretro.mupen64plus
- libretro.neocd
- libretro.nestopia
- libretro.np2kai
- libretro.nxengine
- libretro.o2em
- libretro.opera
- libretro.parallel-n64
- libretro.pcsx-rearmed
- libretro.pcsx2
- libretro.picodrive
- libretro.play
- libretro.ppsspp
- libretro.prboom
- libretro.prosystem
- libretro.puae
- libretro.quicknes
- libretro.same_cdi
- libretro.sameboy
- libretro.scummvm
- libretro.smsplus-gx
- libretro.snes9x
- libretro.snes9x2002
- libretro.snes9x2005
- libretro.snes9x2005-plus
- libretro.snes9x2010
- libretro.stella
- libretro.stella2014
- libretro.swanstation
- libretro.tgbdual
- libretro.thepowdertoy
- libretro.tic80
- libretro.twenty-fortyeight
- libretro.vba-m
- libretro.vba-next
- libretro.vecx
- libretro.virtualjaguar
- libretro.yabause
- librist
- libubox-mbedtls
- lime
- linphone
- lutris
- lutris-free
- mbedtls
- mbedtls_2
- mediastreamer
- mediastreamer-openh264
- msilbc
- nanomq
- neko
- nng
- obs-studio
- obs-studio-plugins.advanced-scene-switcher
- obs-studio-plugins.droidcam-obs
- obs-studio-plugins.input-overlay
- obs-studio-plugins.looking-glass-obs
- obs-studio-plugins.obs-3d-effect
- obs-studio-plugins.obs-backgroundremoval
- obs-studio-plugins.obs-command-source
- obs-studio-plugins.obs-freeze-filter
- obs-studio-plugins.obs-gradient-source
- obs-studio-plugins.obs-gstreamer
- obs-studio-plugins.obs-livesplit-one
- obs-studio-plugins.obs-move-transition
- obs-studio-plugins.obs-multi-rtmp
- obs-studio-plugins.obs-mute-filter
- obs-studio-plugins.obs-nvfbc
- obs-studio-plugins.obs-pipewire-audio-capture
- obs-studio-plugins.obs-replay-source
- obs-studio-plugins.obs-rgb-levels-filter
- obs-studio-plugins.obs-scale-to-sound
- obs-studio-plugins.obs-shaderfilter
- obs-studio-plugins.obs-source-clone
- obs-studio-plugins.obs-source-record
- obs-studio-plugins.obs-source-switcher
- obs-studio-plugins.obs-teleport
- obs-studio-plugins.obs-text-pthread
- obs-studio-plugins.obs-transition-table
- obs-studio-plugins.obs-tuna
- obs-studio-plugins.obs-vaapi
- obs-studio-plugins.obs-vertical-canvas
- obs-studio-plugins.obs-vintage-filter
- obs-studio-plugins.obs-vkcapture
- obs-studio-plugins.obs-websocket
- obs-studio-plugins.waveform
- obs-studio-plugins.wlrobs
- openrgb
- openrgb-with-all-plugins
- ortp
- osmo-bsc
- osmo-bts
- osmo-hlr
- osmo-hnbgw
- osmo-hnodeb
- osmo-mgw
- osmo-msc
- osmo-sgsn
- ps3netsrv
- python310Packages.python-mbedtls
- python310Packages.python-mbedtls.dist
- python311Packages.python-mbedtls
- python311Packages.python-mbedtls.dist
- retroarch
- retroarchBare
- retroarchFull
- shadowsocks-libev
- srsran
- trx
- ustream-ssl-mbedtls
- yojimbo
LeSuisse
reviewed
Apr 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. Made almost complete runs of nixpkgs-review on Linux x86_64 and aarch64, no issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This is a partial backport of #300629. Straightforward for
mbedtls_2
, but for 3.x they've helpfully only included the fixes in a release that introduces some API breakage. It's only easy to fish out the patch for one of the issues. This is better than nothing though.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.