goread: init at 1.6.4 #303237
Closed
goread: init at 1.6.4 #303237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sigmanificient
suggested changes
Apr 22, 2024
Co-authored-by: Yohann Boniface <[email protected]>
pbsds
reviewed
Apr 27, 2024
There was a problem hiding this comment.
Please squash the fixup into the init at commit, and split of the maintainer addition to a separate commit
--
Result of nixpkgs-review pr 303237 run on x86_64-linux 1
1 package built:
- goread
- package path fits guidelines
- package name fits guidelines
- package version fits guidelines
- package builds on x86_64-linux
- executables tested on x86_64-linux
-
meta.descriptionis set and fits guidelines -
meta.licensefits upstream license -
meta.platformsis set -
meta.maintainersis set - build time only dependencies are declared in
nativeBuildInputs - source is fetched using the appropriate function
- the list of
phasesis not overridden - when a phase (like
installPhase) is overridden it starts withrunHook preInstalland ends withrunHook postInstall. - patches have a comment describing either the upstream URL or a reason why the patch wasn't upstreamed
- patches that are remotely available are fetched rather than vendored
Comment on lines
+10194
to
+10199
| kanielrkirby = { | ||
| email = "[email protected]"; | ||
| github = "kanielrkirby"; | ||
| githubId = 77940607; | ||
| name = "Kaniel Kirby"; | ||
| }; |
There was a problem hiding this comment.
please split this into a separate commit titled maintainers: add kanielrkirby
|
Closed in favor of #315903 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adding the
goreadpackage.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.