Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solitaire-tui: init at 0-unstable-2023-04-20 #303222

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Conversation

nyadiia
Copy link
Contributor

@nyadiia nyadiia commented Apr 10, 2024

Description of changes

solitare-tui is a version of Klondike solitaire for the terminal
github/homepage: https://github.com/brianstrauch/solitaire-tui

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nyadiia nyadiia changed the title solitare-tui: init at 0.1.0 solitare-tui: init at 0-unstable-2023-04-20 Apr 10, 2024
@nyadiia nyadiia marked this pull request as ready for review April 10, 2024 22:06
@nyadiia nyadiia force-pushed the solitare-tui branch 2 times, most recently from 7c92db1 to 5163f9b Compare April 11, 2024 19:17
@nyadiia nyadiia changed the title solitare-tui: init at 0-unstable-2023-04-20 solitaire-tui: init at 0-unstable-2023-04-20 Apr 11, 2024
@nyadiia
Copy link
Contributor Author

nyadiia commented Apr 11, 2024

most recent force pushes was me realizing that i spelled solitaire wrong... only thing wrong now is my branch name which shouldn't matter

Copy link
Contributor

@iFreilicht iFreilicht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built fine and works perfectly on aarch64-darwin. Package itself is trivial.

@Aleksanaa Aleksanaa merged commit 19e55ce into NixOS:master Apr 18, 2024
34 checks passed
Copy link
Contributor

Successfully created backport PR for release-23.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants