sss_code: init at 0.1.9

[krovuxdev]

Description of changes

sss is a command tools for screenshots and code snippets.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[Aleksanaa]

1. Please move to pkgs/by-name. Other directories needs top-level reference or package sets reference.
2. Looks like you are contributing for the first time. Please add your name to maintainers-maintainer-list.nix following its examples.
3. It's recommended to leave some blank lines between attributes to improve readability. You can refer to how other packages do it.

[krovuxdev]

Hello @Aleksanaa :)
I've addressed the three points mentioned earlier. Here's where we stand:

• Moved to pkgs/by-name: Moved the package to pkgs/by-name as requested.
• Added name to maintainers-maintainer-list.nix: Added my name following the examples provided since it's my first
• Added whitespace between attributes: Updated the code to include whitespace between attributes for improved readability.

Please review these changes, and let me know if there's anything else I need to address.

Thanks you

[Aleksanaa]

Please squash all your commits leaving only two:

• maintainers: add krovuxdev
• sss: init at 0.1.8

[krovuxdev]

Hi @Aleksanaa, could you please review the code to see if it's okay now?

[Aleksanaa]

Please squash all your commits leaving only two:

• maintainers: add krovuxdev
• sss: init at 0.1.8

[krovuxdev]

@Aleksanaa Hello, thank you for bringing it to my attention. Could you please review my commits to see if they are okay?

[Aleksanaa]

The maintainer addition commit message is specified in https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#commit-conventions.

[krovuxdev]

The maintainer addition commit message is specified in https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#commit-conventions.

Ok, thank you, and now please, review my commits to see if they are correct

[Aleksanaa]

@ofborg eval

[Aleksanaa]

Suggested change

	rev = "sss_code/v{version}";
	rev = "sss_code/v${version}";

[Aleksanaa]

Also your Cargo.Lock is different from the file in the 0.1.8 tag of the repo, but the same with one in the main branch. Seems to be a mistake.

[krovuxdev]

Also your Cargo.Lock is different from the file in the 0.1.8 tag of the repo, but the same with one in the main branch. Seems to be a mistake.

@Aleksanaa, yes, that's why I'm using "main" instead of "sss_code/v0.1.8". As you mentioned, the "sss_code/v0.1.8" is quite old. Additionally, a friend advised me to use "main" because it represents the latest version. Remember, you advised me to change the rev to "sss_code" in package.nix.

[Aleksanaa]

@Aleksanaa, yes, that's why I'm using "main" instead of "sss_code/v0.1.8". As you mentioned, the "sss_code/v0.1.8" is quite old. Additionally, a friend advised me to use "main" because it represents the latest version. Remember, you advised me to change the rev to "sss_code" in package.nix.

Yes, but main is not 0.1.8 as you wrote in the commit message. It is 0.1.8-unstable-2024-03-30. And three months is not a long time interval. If you encounter a bug or build failure, you should use patches to backport a small part of the commit from main branch. Also using Cargo.Lock that is inconsistent with the author's source code will increase the probability of hidden bugs.

[krovuxdev]

@Aleksanaa, yes, that's why I'm using "main" instead of "sss_code/v0.1.8". As you mentioned, the "sss_code/v0.1.8" is quite old. Additionally, a friend advised me to use "main" because it represents the latest version. Remember, you advised me to change the rev to "sss_code" in package.nix.

Yes, but main is not 0.1.8 as you wrote in the commit message. It is 0.1.8-unstable-2024-03-30. And three months is not a long time interval. If you encounter a bug or build failure, you should use patches to backport a small part of the commit from main branch. Also using Cargo.Lock that is inconsistent with the author's source code will increase the probability of hidden bugs.

@Aleksanaa, if I set the version as "sss-unstable-2024-03-29" or "unstable-2024-03-30", is that sufficient?

[Aleksanaa]

No. It doesn't fit the versioning guidelines in https://github.com/NixOS/nixpkgs/tree/master/pkgs#package-naming. And although there is currently no policy whether to uses the -git version, a project that was released three months ago (and this release is a valid) is probably not within the suitable scope.

[krovuxdev]

I've updated the version of sss_code and also changed the title of my PR. I'll create another PR for sss_cli shortly. Does that sound better?

[Aleksanaa]

Please add a comment here why deleting this.

[krovuxdev]

Wait! xd

[krovuxdev]

Done!

[krovuxdev]

@ofborg eval

[Aleksanaa]

@ofborg build

[Aleksanaa]

@ofborg build sss_code

[Aleksanaa]

error: builder for '/nix/store/i0kfrxx1cpikb5rlcl7p1262vgyvr4dr-crate-serde_repr-0.1.19.tar.gz.drv' failed with exit code 1;
       last 7 log lines:
       >
       > trying https://crates.io/api/v1/crates/serde_repr/0.1.19/download
       >   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
       >                                  Dload  Upload   Total   Spent    Left  Speed
       >   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
       > curl: (35) Send failure: Connection reset by peer
       > error: cannot download crate-serde_repr-0.1.19.tar.gz from any mirror
       For full logs, run 'nix log /nix/store/i0kfrxx1cpikb5rlcl7p1262vgyvr4dr-crate-serde_repr-0.1.19.tar.gz.drv'.
error: builder for '/nix/store/65pz36pyb76bkvz56bnpdph1z5swdd0y-crate-tauri-winrt-notification-0.2.0.tar.gz.drv' failed with exit code 1;
       last 7 log lines:
       >
       > trying https://crates.io/api/v1/crates/tauri-winrt-notification/0.2.0/download
       >   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
       >                                  Dload  Upload   Total   Spent    Left  Speed
       >   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
       > curl: (35) Send failure: Connection reset by peer
       > error: cannot download crate-tauri-winrt-notification-0.2.0.tar.gz from any mirror
       For full logs, run 'nix log /nix/store/65pz36pyb76bkvz56bnpdph1z5swdd0y-crate-tauri-winrt-notification-0.2.0.tar.gz.drv'.

@ofborg build sss_code

[krovuxdev]

@Aleksanaa And why this error of tauri?
sss_code does not use tauri

[krovuxdev]

ahhh now I see, there is a tauri in cargo.lock. ok

[afh]

According to the recommendations for meta attributes description should not start with an article and avoid subjective language, hence I propose to use the following shortened description from the projects readme:

Suggested change

	description = "A CLI/Lib to take amazing screenshot of code";
	description = "Libraries and tools for building screenshots in a high-performance image format";