buildGoModule: vendorHash fixes for proxyVendor and Go 1.22 #301928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirillrdy
reviewed
Apr 5, 2024
nevivurn
force-pushed
the
feat/gomod-workvendor
branch
from
c784957
to
8cd1c99
Compare
|
Dropping conflicting commits, as their hash should have been updated during the update. |
nevivurn
force-pushed
the
feat/gomod-workvendor
branch
2 times, most recently
from
a05ac84
to
c552b6e
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3784 |
| @@ -142,6 +142,7 @@ Many attributes [controlling the build phase](#variables-controlling-the-build-p | |||
| - [`patchFlags`](#var-stdenv-patchFlags) | |||
| - [`postPatch`](#var-stdenv-postPatch) | |||
| - [`preBuild`](#var-stdenv-preBuild) | |||
| - `env` | |||
There was a problem hiding this comment.
I think we should add at least a sentence here to explain things
There was a problem hiding this comment.
@SuperSandro2000 i think given context, this is adequate, I had the same first reaction myself
There was a problem hiding this comment.
You do have a point, the other attrs are mostly self-explanatory while env might be a bit confusing as to why it's needed.
I added a short sentence to mention GOWORK.
nevivurn
force-pushed
the
feat/gomod-workvendor
branch
from
c552b6e
to
f190aa8
Compare
SuperSandro2000
approved these changes
Apr 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.