Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release 23.11] searxng 2023-10-31 -> 2024-03-08; uwsgi 2.0.23 -> 2.0.24 #301920

Merged

Conversation

JohnRTitor
Copy link
Contributor

@JohnRTitor JohnRTitor commented Apr 5, 2024

Description of changes

Backport
searxng: 2023-10-31 -> 2024-03-08
uwsgi: 2.0.23 -> 2.0.24

Backport needed due to upstream bug
Closes #301912

Things done

  • Built on platform(s)
    • x86_64-linux

Add a 👍 reaction to pull requests you find important.

@SuperSandro2000
Copy link
Member

Do we really need the uwsgi backport?

@JohnRTitor
Copy link
Contributor Author

@benaryorg can answer that, I added it as per the issue description.

Copy link
Contributor

@999eagle 999eagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested this but the changes look good. While I don't think backporting the uwsgi update is strictly necessary it doesn't hurt either.

@benaryorg
Copy link
Contributor

@benaryorg can answer that, I added it as per the issue description.

I only included it in the workaround because otherwise the dependencies didn't align (i.e. no python application found) and an override would've caused package rebuilds.
Using unstable.pkgs.searxng.override { inherit (pkgs) python3; } seems to work nicely, so the uwsgi bump shouldn't be required, although as mentioned by others it probably wouldn't hurt, it being a bugfix release with a reasonable changelog, but that'd be one for the maintainers to decide IMHO.

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Apr 12, 2024

@GrahamcOfBorg test searx

@SuperSandro2000 SuperSandro2000 merged commit c561445 into NixOS:release-23.11 Apr 12, 2024
24 of 26 checks passed
@JohnRTitor JohnRTitor deleted the backport-searxng-to-23.11 branch April 12, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants